Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make embedding bucket configurable #1726

Merged
merged 30 commits into from
May 17, 2024
Merged

Make embedding bucket configurable #1726

merged 30 commits into from
May 17, 2024

Conversation

ua741
Copy link
Member

@ua741 ua741 commented May 14, 2024 •
edited

Description

Tests

  • New ml data is doing to new bucket
  • For existing embedding, fall back logic is working as expected, we are returning the object immediately and copying the object to new bucket in an async manner.
  • Verified that the dc values were getting updated correctly on copy or insert.
  • Verified that on deletion, we are deleting files from all dcs where the derived file is present.

mnvr
mnvr approved these changes May 14, 2024
View reviewed changes
server/pkg/controller/embedding/controller.go Outdated Show resolved Hide resolved
@ua741 ua741 merged commit 401cf92 into main May 17, 2024
2 checks passed
@ua741 ua741 deleted the make_embedding_bucket_configurable branch May 17, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnvr mnvr mnvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ua741 @mnvr