mobile: pulling server ssl context out of mobile build #34144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssawilk
force-pushed
the
context_manager
branch
5 times, most recently
from
fe87431
to
d054cde
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
context_manager
branch
from
d054cde
to
c341ec4
Compare
alyssawilk
force-pushed
the
context_manager
branch
from
4a88d2b
to
1320e8f
Compare
|
/retest |
alyssawilk
requested review from
RyanTheOptimist,
abeyad and
fredyw
as code owners
ggreenway
reviewed
May 20, 2024
source/common/tls/utility.cc
Outdated
| @@ -192,22 +192,20 @@ std::vector<std::string> Utility::getSubjectAltNames(X509& cert, int type, bool | |||
|
|
|||
| std::string Utility::generalNameAsString(const GENERAL_NAME* general_name) { | |||
| std::string san; | |||
| ASN1_STRING* str; | |||
There was a problem hiding this comment.
Changes in this file seem unrelated. Revert? Or if you like them, ASN1_STRING* str = nullptr; to avoid possibility of uninitialized pointer in future changes.
There was a problem hiding this comment.
yeah this was a coverage improvement to make up for not e2e testing the factory creation failing. I could alternately add a unit test and not link that in but seems overkill.
ggreenway
approved these changes
May 20, 2024
|
/retest |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
/wait on CI |
|
/wait on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Risk Level: low
Testing: updated tests
Docs Changes: n/a
Release Notes: n/a
envoyproxy/envoy-mobile#176