route config: moving the route provider manager to its own file #34155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
rds3
branch
2 times, most recently
from
11ca003
to
b2ac48c
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
adisuissa
approved these changes
May 15, 2024
| #include <queue> | ||
| #include <string> | ||
|
|
||
| #include "envoy/admin/v3/config_dump.pb.h" |
There was a problem hiding this comment.
So many included files :) crazy
RyanTheOptimist
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes a utility which had switch-and-panic calls in favor of explicitly calling the create functions inline.
Risk Level: low: mostly code move.
Testing: n/a
Docs Changes: n/a
Release Notes: n/a