mobile: first pass at hasData up calls #34180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
requested review from
RyanTheOptimist,
abeyad and
fredyw
as code owners
fredyw
approved these changes
May 15, 2024
abeyad
reviewed
May 15, 2024
| @@ -14,6 +14,8 @@ | |||
| #include "library/common/stream_info/extra_stream_info.h" | |||
| #include "library/common/system/system_helper.h" | |||
|
|
|||
| ABSL_FLAG(bool, envoy_reloadable_features_report_available_data, false, ""); // NOLINT | |||
There was a problem hiding this comment.
is this to avoid declaring the flag in runtime_features.cc?
| // data from a server. | ||
| data_available_timer_ = | ||
| http_client_.dispatcher_.createTimerPostDrain([this]() { reportDataAvailable(); }); | ||
| data_available_timer_->enableTimer(std::chrono::seconds(1), nullptr); |
There was a problem hiding this comment.
should this be something like 5ms, so we know if we're immediately blocked on data?
| if (Runtime::runtimeFeatureEnabled("envoy.reloadable_features.report_available_data")) { | ||
| // Drain must have been called for us to get to the point we've received | ||
| // data from a server. | ||
| data_available_timer_ = |
There was a problem hiding this comment.
presumably, by (re-)creating the data_available_timer_, we delete the old one, thereby cancelling the timer enabled.
| @@ -293,6 +312,7 @@ void Client::DirectStreamCallbacks::onComplete() { | |||
| if (elapsed > SlowCallbackWarningThreshold) { | |||
| ENVOY_LOG_EVENT(warn, "slow_on_complete_cb", "{}ms", elapsed.count()); | |||
| } | |||
| data_available_timer_.reset(); | |||
There was a problem hiding this comment.
I think we'll also want to disable this timer if we get a onError ,onCancel or endStream=true
|
going to close this off for now as we think we've found our stall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]