-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to set the hits_addend for a given rate_limit request via a hardcoded dynamic metadata field #34184
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
a2d61d8
to
673a527
Compare
The changes to I'm also not sure exactly where the docs should live for this feature. I definitely think that updating the release notes make sense and I can do that, but it could definitely also make sense to add it to the proper docs. |
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
At a high level this seems fine to me. For documentation I would add to the filter specific documentation as well as the release notes. /wait |
Ok, I'll add the documentation, are there any code changes you'd like me to make while I'm at it? |
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
…addend_dynamic_metadata Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
/retest |
format failure /wait |
Commit Message: Adds the ability to set the hits_addend for a given rate_limit request via a hardcoded dynamic metadata field: envoy.ratelimit:hits_addend.
Additional Description:
Risk Level: Low
Testing: Added unit test. I have also manually tested this using gloo-edge as the control-plane.
Docs Changes:
Release Notes:
Platform Specific Features: N/A
[Optional Runtime guard:] N/A
[Optional Fixes #Issue] N/A
[Optional Fixes commit #PR or SHA] N/A
[Optional Deprecated:] N/A
[Optional API Considerations:] N/A