Clarify DOWNSTREAM_LOCAL_ADDRESS. #34185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the doc aligned with the actual behavior when proxy protocol filter is used on listener. Signed-off-by: Jianfei Hu <jianfei.hu@clickhouse.com>
|
Hi @incfly, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
incfly
commented
May 16, 2024
| @@ -695,6 +695,12 @@ UDP | |||
| If the original connection was redirected by iptables TPROXY, and the listener's transparent | |||
| option was set to true, this represents the original destination address and port. | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
This code block is copied from DOWNSTREAM_DIRECT_REMOTE_ADDRESS just to be consistent.
ravenblackx
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the doc aligned with the actual behavior when proxy protocol filter is used on listener. We consistently set this in various places.
https://github.com/search?q=repo%3Aenvoyproxy%2Fenvoy%20Network%3A%3AProxyProtocolFilterState%3A%3Akey()&type=code
Commit Message:
Additional Description:
Risk Level: N/A
Testing:
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]