Go Network Filter: support enableHalfClose for upstream connection #34196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: duxin <duxin40@gmail.com>
Signed-off-by: duxin <duxin40@gmail.com>
Signed-off-by: duxin <duxin40@gmail.com>
支持network golang connection enable-half-close
Signed-off-by: duxin <duxin40@gmail.com>
add enableHalfClose code in example
|
Hi @duxin40, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: duxin <duxin40@gmail.com>
format upstream.cc
|
Thanks @duxin40 , looks good after a quick look, will take a deep look soon. |
doujiang24
reviewed
May 18, 2024
Signed-off-by: duxin <duxin40@gmail.com>
Signed-off-by: duxin <duxin40@gmail.com>
Signed-off-by: duxin <duxin40@gmail.com>
Signed-off-by: duxin40 <33946910+duxin40@users.noreply.github.com>
add panic when connEnableHalfCloseFunc is nil
Signed-off-by: duxin <duxin40@gmail.com>
format code for filter.go
Signed-off-by: duxin <duxin40@gmail.com>
update panic info for EnableHalfClose func
|
@doujiang24 sorry for clicking on the button (request for review) 😂, could you please help approve again~ |
doujiang24
approved these changes
May 22, 2024
|
Thanks @zuercher , as extension maintainer does not have permission to merge/approve, please help to merge it manually, thanks very much :) |
phlax
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In summary
This PR will add the support to enableHalfClose for upstream connection in go network filter, if user set enableHalfClose to true, reading a remote upstream half-close will not fully close the connection.
Future Plan
support for go network filter can be configured together with HCM, so user can specify upstream conn enableHalfClose on L4 and manage traffic on L7.
Let me know if this sounds reasonable, and thank you all for the review!
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]