Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backports: backporting 34142 #34200

Merged
merged 1 commit into from
May 17, 2024

Conversation

alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 16, 2024

Backport of #32336

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34200 was opened by alyssawilk.

see: more, trace.

Copy link

CC @envoyproxy/runtime-guard-changes: FYI only for changes made to (source/common/runtime/runtime_features.cc).

🐱

Caused by: #34200 was opened by alyssawilk.

see: more, trace.

@phlax
Copy link
Member

phlax commented May 16, 2024

@alyssawilk what happened to the original commit message?

Remove debug assertion and add more checks for assessing upstream_requests related to timing.

Signed-off-by: Boteng Yao <boteng@google.com>
@alyssawilk alyssawilk marked this pull request as ready for review May 16, 2024 19:25
@alyssawilk
Copy link
Contributor Author

fixed and de-drafted :-)

@phlax phlax enabled auto-merge (rebase) May 17, 2024 07:06
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk

@phlax phlax merged commit bfeecfa into envoyproxy:release/v1.27 May 17, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants