Update accounts developer docs #12938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good! A few small changes related to readability and reducing word count
setgree
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
minimalsm
requested changes
May 28, 2024
| @@ -8,7 +8,7 @@ An Ethereum account is an entity with an ether (ETH) balance that can send trans | |||
|
|
|||
| ## Prerequisites {#prerequisites} | |||
|
|
|||
| To help you better understand this page, we recommend you first read through our [introduction to Ethereum](/developers/docs/intro-to-ethereum/). | |||
| We recommend you first read through our [introduction to Ethereum](/developers/docs/intro-to-ethereum/). | |||
There was a problem hiding this comment.
The phrase "We recommend you first..." is a recurring pattern in our developer documentation within the prerequisites section. If we believe this should be changed, it warrants a separate discussion rather than making isolated changes.
To maintain consistency, I suggest we revert this line.
Suggested change
| We recommend you first read through our [introduction to Ethereum](/developers/docs/intro-to-ethereum/). | |
| To help you better understand this page, we recommend you first read through our [introduction to Ethereum](/developers/docs/intro-to-ethereum/). |
minimalsm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks good! I made a few small changes related to readability and reducing word count