Get GitHub file contributors during getStaticProps, cache to avoid rate limit #12942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
content 🖋️
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
run `yarn` automatically on `yarn dev` or `yarn build` to 1- update dependencies if needed, 2- trigger the `postinstall` script which will now remove the git-contributor-cache.json file to start the environment fresh each time
wackerow
requested review from
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
wackerow
force-pushed
the
get-static-contributors
branch
from
d1a3b96
to
ea4fcba
Compare
wackerow
commented
May 17, 2024
| @@ -206,6 +204,7 @@ type DocsLayoutProps = Pick< | |||
| | "lastUpdatedDate" | |||
| | "crowdinContributors" | |||
| | "contentNotTranslated" | |||
| | "gitContributors" | |||
There was a problem hiding this comment.
Note that gitContributors and creowdinContributors will be deprecated in #12969 in favor of a single list of contributors
pettinarip
approved these changes
May 22, 2024
| @@ -8,13 +8,11 @@ import { | |||
| ListItem, | |||
| ModalBody, | |||
| ModalHeader, | |||
| SkeletonText, | |||
There was a problem hiding this comment.
bye bye 💀 oh much cleaner now
| response.status === 403 && | ||
| response.headers.get("X-RateLimit-Remaining") === "0" | ||
| ) { | ||
| const resetTime = response.headers.get("X-RateLimit-Reset") as string |
There was a problem hiding this comment.
Nice use of headers for this, TIL
This was referenced May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates fetching for GitHub contributors for each page, removing the client-side fetch, replacing with cached solution during getStaticProps (server-side), removing all error/loading conditionals allowing the component the render immediately.
useClientSideGitHub*hooksfetchGitHistory.tsscript, designed to be run server-side during getStaticProps[...slug].tsx]page component that stores already fetched data.getStaticProps, and passed forward. Updated consuming components to remove all conditionals, as this data should never be in a loading or error state anymore.isDesktopboolean inside FileContributors and replaced withhideBelow="md"to fix the initial patch render glitch where this component was empty to start.Preview URL