WIP: implement EIP-5806 (type 4) delegate transaction #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is similar to eip-2803? I’d love to see something like this championed. :) |
|
EIP-5806 is being actively developed. There are talks of a possible testnet, and inclusion in Prague. We are still far from it, and it may not happen at all, but this PR is part of the "feasibility evaluation" |
Amxx
commented
Mar 8, 2024
Amxx
commented
Mar 8, 2024
Amxx
commented
Mar 8, 2024
| const fragment = getFragment(...args); | ||
| // If an overrides was passed in, copy it and normalize the values | ||
| if (fragment.inputs.length + 1 === args.length) { | ||
| Object.assign(args[args.length - 1], { type: 4 }); |
There was a problem hiding this comment.
Current implementation "leaks" types: 4 into the args[args.length - 1] ... that may be reused elsewhere.
Suggested change
| Object.assign(args[args.length - 1], { type: 4 }); | |
| args[args.length - 1] = Object.assign({}, args[args.length - 1], { type: 4 }); |
There was a problem hiding this comment.
maybe we need to copy the args array first ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress implementation of EIP-5806 (type 4) delegate transactions.
For references:
TODO: