-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortcut emitDeviceEvent in bridgeless (2nd attempt) #44590
Conversation
This pull request was exported from Phabricator. Differential Revision: D57435750 |
Summary: emitDeviceEvent is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: philIip Differential Revision: D57435750
This pull request was exported from Phabricator. Differential Revision: D57435750 |
Summary: emitDeviceEvent is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: philIip Differential Revision: D57435750
This pull request was exported from Phabricator. Differential Revision: D57435750 |
Summary: Store callable modules as either a factory function or an object, so we can skip invoking the factory function for frequently accessed objects. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D57338528
Summary: emitDeviceEvent is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: philIip Differential Revision: D57435750
This pull request was exported from Phabricator. Differential Revision: D57435750 |
Base commit: 5a6b64f |
This pull request has been merged in b2ced62. |
This pull request was successfully merged by @javache in b2ced62. When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: facebook#44590 emitDeviceEvent is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module. Changelog: [Internal] Reviewed By: philIip Differential Revision: D57435750 fbshipit-source-id: 1c120073ac80afd95deb8e3e6f1c00c2d3d80133
Summary:
emitDeviceEvent is frequently used for perf-critical operations such as sending network responses from native to JS. We don't need to go through JavaScriptModule Proxy (which is missing caching in bridgeless) and instead can immediately invoke the callable JS module.
Changelog: [Internal]
Differential Revision: D57435750