compiler: Improve ValidateNoRefAccessInRender to ignore access in effects #29151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
josephsavona
added a commit
that referenced
this pull request
May 17, 2024
…ects ghstack-source-id: fb6352a1788b7bdbebb40d5b844b711ef87d6771 Pull Request resolved: #29151
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 1d6eebf...d294bba Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
…cess in effects" Improves ValidateNoRefAccessInRender (still disabled by default) to properly ignore ref access within effects. This includes allowing ref access within functions that are only transitively called from an effect. While I was here I also added some extra test fixtures for allowing global mutation in effects. [ghstack-poisoned]
josephsavona
added a commit
that referenced
this pull request
May 17, 2024
…ects Improves ValidateNoRefAccessInRender (still disabled by default) to properly ignore ref access within effects. This includes allowing ref access within functions that are only transitively called from an effect. While I was here I also added some extra test fixtures for allowing global mutation in effects. ghstack-source-id: fb6352a1788b7bdbebb40d5b844b711ef87d6771 Pull Request resolved: #29151
josephsavona
added a commit
that referenced
this pull request
May 20, 2024
…ects Improves ValidateNoRefAccessInRender (still disabled by default) to properly ignore ref access within effects. This includes allowing ref access within functions that are only transitively called from an effect. While I was here I also added some extra test fixtures for allowing global mutation in effects. ghstack-source-id: fb6352a1788b7bdbebb40d5b844b711ef87d6771 Pull Request resolved: #29151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Improves ValidateNoRefAccessInRender (still disabled by default) to properly ignore ref access within effects. This includes allowing ref access within functions that are only transitively called from an effect.
While I was here I also added some extra test fixtures for allowing global mutation in effects.