Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Echo server #118

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: Echo server #118

wants to merge 21 commits into from

Conversation

nkBrew
Copy link

@nkBrew nkBrew commented Oct 17, 2023

Description:
Implemented controllers that implement the same functionality for Postman's echo server

The controllers in question cover
Auth

  • basic
  • digest
  • hawk
  • oauth1.0

Cookies

  • set
  • get
  • delete

Utilities

  • stream
  • encoding/utf8
  • gzip
  • deflate
  • ip

Time

  • now
  • valid
  • format
  • extract
  • subtract
  • start
  • before
  • after
  • between
  • leapyear

Notes:
- I still have a bit of cleanup I want to do to deduplicate some stuff. Wanted to get the PR up for review though.

Closes:
#106

@netlify
Copy link

netlify bot commented Oct 17, 2023

‼️ Deploy request for staging-firecamp-dev rejected.

Name Link
🔨 Latest commit ed0f1f9

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@nkBrew
Copy link
Author

nkBrew commented Oct 17, 2023

I've never heard of a Check Spelling job. What am I supposed to do to fix it?

Do I do something outlined here? https://github.com/firecamp-dev/firecamp/actions/runs/6540867134/attempts/1#summary-17761524652

@jsoref
Copy link
Contributor

jsoref commented Oct 17, 2023

Add ^\Qpackages/firecamp-echo-server/src/assets/unicodedemo.html\E$ to .github/actions/spelling/excludes.txt

@nkBrew
Copy link
Author

nkBrew commented Oct 17, 2023

Add ^\Qpackages/firecamp-echo-server/src/assets/unicodedemo.html\E$ to .github/actions/spelling/excludes.txt

helped with a lot of the issues thanks.

Still getting some though

Gzna
RKC
rpaxn
ruxnpa
rxn
Streamable
Successfull
unicodedemo
werxhqb
xrunpaw

Doesn't seem to like the keys. I can fix that by moving them to a separate file and ignoring that as well.
Don't really know how to fix Streamable and unicodedemo though. Those are kindof required.

@nkBrew
Copy link
Author

nkBrew commented Oct 23, 2023

Cleaned up the PR and fixed the spelling for the spelling jobs.

@Nishchit14
Copy link
Contributor

@nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores.

@nkBrew
Copy link
Author

nkBrew commented Oct 26, 2023

@nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores.

Yeah it's ready for review now. I'll update the description

@Nishchit14
Copy link
Contributor

will try it this weekend!!

Copy link
Contributor

@Nishchit14 Nishchit14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested all APIs except cookies (as they are not supported in Firecamp yet). all looks good to me.

I have one question, Have you cross-checked echo server APIs from the PM collection? Any APIs are pending to be implemented in FC? please confirm :)

packages/firecamp-echo-server/src/assets/credentials.ts Outdated Show resolved Hide resolved
@nkBrew
Copy link
Author

nkBrew commented Nov 2, 2023

I have one question, Have you cross-checked echo server APIs from the PM collection? Any APIs are pending to be implemented in FC? please confirm :)

I cross checked the API endpoints that had return yet to be implemented on them with the Postman echo collection. I can double check later today if there are some missing.

@Nishchit14
Copy link
Contributor

sure @nkBrew take your time :)

@Nishchit14
Copy link
Contributor

Hi @nkBrew, do you have a plan to finish pending routes in the coming days?

@nkBrew
Copy link
Author

nkBrew commented Nov 12, 2023

Hi @nkBrew, do you have a plan to finish pending routes in the coming days?

@Nishchit14 Yeah, was able to do it. Just uploaded the changes.

@Nishchit14
Copy link
Contributor

@nkBrew thank you for the update, eager to deploy the echo server on the production server :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants