fix: Support creating file with open_file_nonblock
#4028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
added
Priority: Low
JonathanWoollett-Light
force-pushed
the
create-log-file
branch
3 times, most recently
from
564f44b
to
8f21d19
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4028 +/- ##
==========================================
- Coverage 82.65% 82.65% -0.01%
==========================================
Files 221 221
Lines 28169 28170 +1
==========================================
Hits 23283 23283
- Misses 4886 4887 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JonathanWoollett-Light
force-pushed
the
create-log-file
branch
from
8f21d19
to
e91917c
Compare
Updates the `OpenOptions` with `.create(true)` to support creating a file when if it doesn't exist. This also brings the functionality inline with the documentation which notes `Create and opens a File for writing to it.`. This improves usability simplifying setting up the logger. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
create-log-file
branch
from
e91917c
to
a784d58
Compare
JonathanWoollett-Light
changed the title
open_file_nonblockopen_file_nonblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
OpenOptionswith.create(true)to support creating a file when if it doesn't exist.Reason
This also brings the functionality inline with the documentation which notes
Create and opens a File for writing to it.. This improves usability simplifying setting up the logger.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.