Add PVH related integration tests #4073
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feature/pvh #4073 +/- ##
============================================
Coverage 82.36% 82.36%
============================================
Files 225 225
Lines 28630 28630
============================================
Hits 23580 23580
Misses 5050 5050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
pvh-tests
branch
2 times, most recently
from
de3083a
to
8be04a4
Compare
roypat
force-pushed
the
pvh-tests
branch
3 times, most recently
from
ce3237e
to
b096346
Compare
roypat
force-pushed
the
pvh-tests
branch
7 times, most recently
from
18cdd9a
to
9a2db96
Compare
roypat
force-pushed
the
pvh-tests
branch
2 times, most recently
from
138e89a
to
91fd93c
Compare
We want to add integration tests for PVH boot, which means we need ci artifacts that have PVH enabled. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
pvh-tests
branch
2 times, most recently
from
1efb582
to
64b1bb5
Compare
Add a test that verifies that firecracker can boot a PVH-enabled linux, and assert that it actually used the PVH boot protocol. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Enabling CONFIG_XEN_PVH=y is for booting on the actual Xen hypervisor. To boot using PVH on a non-Xen hypervisor, set CONFIG_PVH=y. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
|
I'm putting this back into draft until the initrd issues are resolved |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PVH related integration tests, such as
FreeBSD boots successfully inside of firecrackerIt does not on m6a.metalLinux compiled with PVH support meets boottime SLA of 150msPVH is not supported on 4.14, which is the kernel version for which we measure boottime in CI.Since the feature we are testing is "PVH boot protocol", the testing matrix we will use here is "PVH-enabled Linux".
See also #3041
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.