Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add io.github.roseblume.rosary #5252

Closed
wants to merge 10 commits into from

Conversation

RoseBlume
Copy link

@RoseBlume RoseBlume commented May 16, 2024

Please confirm your submission meets all the criteria

This application is a simple bible app designed with the goal of providing Christians with reliable sources to review so that they may come to their own conclusions about their faith.

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:https://github.com/RoseBlume/Rosary
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@hfiguiere
Copy link
Contributor

why did you close the other?

@RoseBlume RoseBlume requested a review from hfiguiere May 16, 2024 22:48
@RoseBlume
Copy link
Author

RoseBlume commented May 16, 2024

why did you close the other?
Errors were appearing when I was trying to push.

@RoseBlume RoseBlume closed this May 16, 2024
@RoseBlume RoseBlume reopened this May 16, 2024
@RoseBlume
Copy link
Author

RoseBlume commented May 16, 2024

bot, build io.github.roseblume.rosary

@RoseBlume RoseBlume changed the title Add Io.GitHub.roseblume.rosary Add io.GitHub.roseblume.rosary May 16, 2024
@flathubbot
Copy link

Queued test build for io.github.roseblume.rosary.

@flathubbot
Copy link

Started test build 121452

@flathubbot
Copy link

Build 121452 failed

@RoseBlume
Copy link
Author

RoseBlume commented May 16, 2024

bot, build io.github.roseblume.rosary

@flathubbot
Copy link

Ignoring bot build request due to repo lookup error: Invalid id flathub.

@flathubbot
Copy link

Queued test build for io.github.roseblume.rosary.

@flathubbot
Copy link

Started test build 121453

@flathubbot
Copy link

Build 121453 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104320/io.github.roseblume.rosary.flatpakref

@RoseBlume
Copy link
Author

@hfiguiere It has passed all the bots checks, can you please confirm that it is ready?

@hfiguiere
Copy link
Contributor

@hfiguiere It has passed all the bots checks, can you please confirm that it is ready?

can you answer unanswered questions?

@RoseBlume
Copy link
Author

RoseBlume commented May 17, 2024

@hfiguiere Errors were appearing when I was trying to push. For some reason it kept saying that it failed to upload everything. It would get to 56% before failing.

@bbhtt bbhtt changed the title Add io.GitHub.roseblume.rosary Add io.github.roseblume.rosary May 17, 2024
@bbhtt
Copy link
Contributor

bbhtt commented May 17, 2024

Can you fix the checklist in the description? This is the second PR where everything is wrong there.

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 17, 2024
@RoseBlume
Copy link
Author

Can you fix the checklist in the description? This is the second PR where everything is wrong there.

@bbhtt Fixed

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 17, 2024
@RoseBlume
Copy link
Author

RoseBlume commented May 17, 2024

Im just wondering but how do these get merged?

@bbhtt
Copy link
Contributor

bbhtt commented May 18, 2024

Into a new repo for your app. You'll have to wait, we batch the merges.

@RoseBlume
Copy link
Author

bot, build io.github.roseblume.rosary

@flathubbot
Copy link

Queued test build for io.github.roseblume.rosary.

@flathubbot
Copy link

Started test build 122271

@flathubbot
Copy link

Build 122271 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105213/io.github.roseblume.rosary.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/io.github.roseblume.rosary

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants