Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.esrille.furiganapad #5256

Closed

Conversation

ShikiOkasaka
Copy link

Please confirm your submission meets all the criteria

  • Please describe your application briefly.

A text editor for writing Japanese text with ruby annotations

  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Support Flatpak esrille/furiganapad#28
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

com.esrille.furiganapad.json
python3-PyICU.json
@ShikiOkasaka ShikiOkasaka changed the title Add manifests Add com.esrille.furiganapad May 17, 2024
@hfiguiere
Copy link
Contributor

bot, build com.esrille.furiganapad

@flathubbot
Copy link

Queued test build for com.esrille.furiganapad.

@flathubbot
Copy link

Started test build 121593

@flathubbot
Copy link

Build 121593 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104536/com.esrille.furiganapad.flatpakref

@@ -0,0 +1,30 @@
{
"id" : "com.esrille.furiganapad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The website is at https://www.esrille.com/ (just a public note)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be troublesome for the verification process afaik.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have enabled the redirect from our naked domain to ‘www.’ It will take effect within 48 hours.

@bbhtt
Copy link
Contributor

bbhtt commented May 17, 2024

Is it working? I don't have Japanese input methods.

Also seems it cannot create some session file:

ERROR:application:Could not read '/home/test/.var/app/com.esrille.furiganapad/data/furiganapad/session'
Traceback (most recent call last):
  File "/app/share/furiganapad/src/application.py", line 63, in do_activate
    with open(pathname, 'r') as file:
         ^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/test/.var/app/com.esrille.furiganapad/data/furiganapad/session'

This should probably be reported upstream.

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 17, 2024
@ShikiOkasaka
Copy link
Author

Is it working? I don't have Japanese input methods.

Also seems it cannot create some session file:

ERROR:application:Could not read '/home/test/.var/app/com.esrille.furiganapad/data/furiganapad/session'
Traceback (most recent call last):
  File "/app/share/furiganapad/src/application.py", line 63, in do_activate
    with open(pathname, 'r') as file:
         ^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/test/.var/app/com.esrille.furiganapad/data/furiganapad/session'

This should probably be reported upstream.

The exception is expected and handled within the application. If you don't have ibus-hiragana installed, furiganapad works as an ordinary text editor.

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 17, 2024
@barthalion
Copy link
Member

bot, build com.esrille.furiganapad

@flathubbot
Copy link

Queued test build for com.esrille.furiganapad.

@flathubbot
Copy link

Started test build 122403

@flathubbot
Copy link

Build 122403 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105344/com.esrille.furiganapad.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/com.esrille.furiganapad

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants