Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add com.voxdsp.TempleDriver #5258

Closed
wants to merge 14 commits into from

Conversation

BeverlyCode
Copy link

@BeverlyCode BeverlyCode commented May 18, 2024

Please confirm your submission meets all the criteria

  • [A 3D video game based on Terry A. Davis] Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link:
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.)

@BeverlyCode
Copy link
Author

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 121700

@BeverlyCode
Copy link
Author

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Build 121700 failed

@flathubbot
Copy link

Started test build 121702

@flathubbot
Copy link

Build 121702 failed

@BeverlyCode
Copy link
Author

Build 121702 failed

Upload failed?

@bbhtt
Copy link
Contributor

bbhtt commented May 18, 2024

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 121760

@flathubbot
Copy link

Build 121760 failed

@BeverlyCode
Copy link
Author

Build 121760 failed

Even stranger, this one succeeded, but failed?! O_o

@BeverlyCode
Copy link
Author

BeverlyCode commented May 18, 2024

It might be because it uses pre-built .o files for x86 only? If I exclude aarch maybe it will work? Is it possible to exclude aarch as a build target?

@hfiguiere
Copy link
Contributor

Build 121760 failed

Even stranger, this one succeeded, but failed?! O_o

no it didn't

HEAD is now at a396f9e Update main.c
FB: Running: git lfs checkout
FB: Running: git rev-parse --verify --quiet a396f9e83e57c4113ac25f7da94f056235994258:.gitmodules
�]2;flatpak-builder: Installing templedriver�Running: cc main.c glad_gl.c assets/high/alien.o assets/high/bg.o assets/high/car.o assets/high/cia.o assets/high/e1.o assets/high/e2.o assets/high/track.o assets/high/train.o assets/high/terry.o -I inc -Ofast -L/app/lib -lglfw -lasound -pthread -lm -o templedriver
FB: Running 'flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/templedriver --nofilesystem=host:reset --filesystem=/srv/buildbot/worker/build-aarch64/build/.flatpak-builder/build/templedriver-1 --bind-mount=/run/build/templedriver=/srv/buildbot/worker/build-aarch64/build/.flatpak-builder/build/templedriver-1 --build-dir=/run/build/templedriver --bind-mount=/run/ccache=/srv/buildbot/worker/build-aarch64/build/.flatpak-builder/ccache --unshare=network --env=SOURCE_DATE_EPOCH=1716032194 '--env=CFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer ' '--env=CXXFLAGS=-O2 -pipe -g -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer ' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed ' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=80 /srv/buildbot/worker/build-aarch64/build/.flatpak-builder/rofiles/rofiles-6oMr52 /bin/sh -c 'cc main.c glad_gl.c assets/high/alien.o assets/high/bg.o assets/high/car.o assets/high/cia.o assets/high/e1.o assets/high/e2.o assets/high/track.o assets/high/train.o assets/high/terry.o -I inc -Ofast -L/app/lib -lglfw -lasound -pthread -lm -o templedriver'' on host
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/alien.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/bg.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/car.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/cia.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/e1.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/e2.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/track.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/train.o' is incompatible with aarch64 output
/usr/lib/gcc/aarch64-unknown-linux-gnu/13.2.0/../../../../aarch64-unknown-linux-gnu/bin/ld: unknown architecture of input file `assets/high/terry.o' is incompatible with aarch64 output
collect2: error: ld returned 1 exit status
FB: host_command_exited_cb 915126 256

@hfiguiere
Copy link
Contributor

It might be because it uses pre-built .o files for x86 only? If I exclude aarch maybe it will work? Is it possible to exclude aarch as a build target?

how about this time you add a build system in the project before you try to build it on flathub. Flatpak build is NOT a build system. Having to call gcc directly is considered a bug.

@hfiguiere
Copy link
Contributor

also why using pre-built?

@hfiguiere
Copy link
Contributor

	<project_license>GPL-2.0-only</project_license>

This is clearly wrong. You can't have GPL-2.0 code that require binaries like that.

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 18, 2024
@BeverlyCode
Copy link
Author

I'll fix it.

@BeverlyCode
Copy link
Author

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 121789

@flathubbot
Copy link

Build 121789 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104732/com.voxdsp.TempleDriver.flatpakref

@BeverlyCode
Copy link
Author

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 121852

@flathubbot
Copy link

Build 121852 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104795/com.voxdsp.TempleDriver.flatpakref

@BeverlyCode
Copy link
Author

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 121866

@flathubbot
Copy link

Build 121866 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104809/com.voxdsp.TempleDriver.flatpakref

@BeverlyCode
Copy link
Author

I'm done. Looks good to me. Had to swap from GLFW to SDL due to ASLA issues.

@hfiguiere
Copy link
Contributor

This is not done:

Please describe your application briefly.

@BeverlyCode
Copy link
Author

This is not done:

Please describe your application briefly.

Is that better? Do you guys actually use the information from the submission now?

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

Yes, we do.

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 19, 2024
@BeverlyCode
Copy link
Author

Yes, we do.

That's interesting, how do you use it exactly if you don't mind me asking, and when did you start to store it outside of the pull requests themselves?

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

To figure out what an app is about when reviewing.

@barthalion
Copy link
Member

bot, build com.voxdsp.TempleDriver

@flathubbot
Copy link

Queued test build for com.voxdsp.TempleDriver.

@flathubbot
Copy link

Started test build 122411

@flathubbot
Copy link

Build 122411 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105352/com.voxdsp.TempleDriver.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/com.voxdsp.TempleDriver

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants