-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.voxdsp.TempleDriver #5258
Conversation
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 121700 |
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Build 121700 failed |
Started test build 121702 |
Build 121702 failed |
Upload failed? |
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 121760 |
Build 121760 failed |
Even stranger, this one succeeded, but failed?! O_o |
It might be because it uses pre-built .o files for x86 only? If I exclude aarch maybe it will work? Is it possible to exclude aarch as a build target? |
no it didn't
|
how about this time you add a build system in the project before you try to build it on flathub. Flatpak build is NOT a build system. Having to call |
also why using pre-built? |
This is clearly wrong. You can't have GPL-2.0 code that require binaries like that. |
I'll fix it. |
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 121789 |
Build 121789 successful
|
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 121852 |
Build 121852 successful
|
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 121866 |
Build 121866 successful
|
I'm done. Looks good to me. Had to swap from GLFW to SDL due to ASLA issues. |
This is not done:
|
Is that better? Do you guys actually use the information from the submission now? |
Yes, we do. |
That's interesting, how do you use it exactly if you don't mind me asking, and when did you start to store it outside of the pull requests themselves? |
To figure out what an app is about when reviewing. |
bot, build com.voxdsp.TempleDriver |
Queued test build for com.voxdsp.TempleDriver. |
Started test build 122411 |
Build 122411 successful
|
/merge |
A repository for this submission has been created: https://github.com/flathub/com.voxdsp.TempleDriver You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you. Thanks! |
Please confirm your submission meets all the criteria