Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add org.fooyin.fooyin #5261

Closed
wants to merge 4 commits into from
Closed

Conversation

eclipseo
Copy link

Fooyin

Fooyin is a music player built around customisation. It offers a growing list of widgets to manage and play your local music collection. It's extendable through the use of plugins and scriptable using FooScript.

Features:

  • Customisable layout
  • Gapless playback
  • Filter and search music collection
  • Create and manage playlists
  • Extendable through plugins
  • Tag editing

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (If not, please explain each non-standard permission.)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about submitting their software to Flathub. Link: Flatpak package ludouzi/fooyin#99 In progress, ownership shall be his too
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed. Software author has acquired the domain name.
  • Any additional patches or files have been submitted to the upstream projects concerned. (If not, explain why.) PR were sent and merged.

Software author must have co-ownership of the repo if approved: https://github.com/ludouzi/

This is my first Flatpak, any advice is greatly appreciated.

Linting:

flatpak run --command=flatpak-builder-lint org.flatpak.Builder manifest org.fooyin.fooyin.yaml
no error

flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream org.fooyin.fooyin.metainfo.xml
? Validation was successful.

flatpak run --command=flatpak-builder-lint org.flatpak.Builder repo repo
{
    "errors": [
        "appstream-remote-icon-not-mirrored",
        "appstream-external-screenshot-url"
    ],
    "message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
}

flatpak run org.fooyin.fooyin
Detected locale "C" with character encoding "ANSI_X3.4-1968", which is not UTF-8.
Qt depends on a UTF-8 locale, and has switched to "C.UTF-8" instead.
If this causes problems, reconfigure your locale. See the locale(1) manual
for more information.
Loaded "qt" translations for locale "en_US" from "/usr/translations"
Failed to load "fooyin" translations for locale "en_US" from "/app/share/fooyin/translations"
Detected locale "C" with character encoding "ANSI_X3.4-1968", which is not UTF-8.
Qt depends on a UTF-8 locale, and has switched to "C.UTF-8" instead.
If this causes problems, reconfigure your locale. See the locale(1) manual
for more information.
Loaded "qt" translations for locale "zh_CN" from "/usr/translations"
Loaded "fooyin" translations for locale "zh_CN" from "/app/share/fooyin/translations"

Translations do work though.

Not sure how to handle the mirroring yet.

@eclipseo eclipseo changed the title Fooyin: a music player built around customisation Add: Fooyin: a music player built around customisation May 18, 2024
@eclipseo eclipseo changed the title Add: Fooyin: a music player built around customisation Add org.fooyin.fooyin May 18, 2024
flathub.json Outdated Show resolved Hide resolved
org.fooyin.fooyin.yaml Outdated Show resolved Hide resolved
@hfiguiere
Copy link
Contributor

Not sure how to handle the mirroring yet.

Just remove "remote" icons from the appstream file.

@hfiguiere
Copy link
Contributor

bot, build org.fooyin.fooyin

@flathubbot
Copy link

Queued test build for org.fooyin.fooyin.

@flathubbot
Copy link

Started test build 121795

@hfiguiere
Copy link
Contributor

Not sure how to handle the mirroring yet.

Just remove "remote" icons from the appstream file.

and I don't see any. Let's see what buildbot has to say.

@flathubbot
Copy link

Build 121795 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104738/org.fooyin.fooyin.flatpakref

@eclipseo
Copy link
Author

bot, build org.fooyin.fooyin

@flathubbot
Copy link

Queued test build for org.fooyin.fooyin.

@flathubbot
Copy link

Started test build 121815

@flathubbot
Copy link

Build 121815 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104758/org.fooyin.fooyin.flatpakref

@eclipseo
Copy link
Author

Ok, I've tested locally, it works fine.

As said, I don't have any remote icon, so I don't get: appstream-remote-icon-not-mirrored.

I do have an external screenshot, but from what I've understood --mirror-screenshots-url=URL will handle it, right?

org.fooyin.fooyin.yaml Outdated Show resolved Hide resolved
org.fooyin.fooyin.yaml Outdated Show resolved Hide resolved
org.fooyin.fooyin.yaml Outdated Show resolved Hide resolved
@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 19, 2024
org.fooyin.fooyin.yaml Outdated Show resolved Hide resolved
@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

I'm seeing a blank window from second launch

Screencast.mp4

@eclipseo
Copy link
Author

bot, build org.fooyin.fooyin

@flathubbot
Copy link

Queued test build for org.fooyin.fooyin.

@eclipseo
Copy link
Author

I'm seeing a blank window from second launch
Screencast.mp4

I can't reproduce this on Plasma 6. I will need to try with a GNOME system like yours maybe.

@eclipseo
Copy link
Author

eclipseo commented May 19, 2024

Screenshot_20240519_062555

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

@flathubbot
Copy link

Started test build 121903

@flathubbot
Copy link

Build 121903 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104847/org.fooyin.fooyin.flatpakref

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

But the window is invisible which is the issue. I can only get it back on second launch by rm-ing all app data from ~/.var/app/app-id and launching again so that it is a "fresh" start.

@ludouzi
Copy link

ludouzi commented May 19, 2024

I've just tried the latest test build in Gnome 46.1 and it runs fine on subsequent launches, so I'm not sure what's happening in your case. I'll have to do some testing.

@eclipseo
Copy link
Author

In the screencast, on your second run, we see the icon of Fooyin in your taskbar.

But the window is invisible which is the issue. I can only get it back on second launch by rm-ing all app data from ~/.var/app/app-id and launching again so that it is a "fresh" start.

What os/GNOME are you using so I can try to repro?

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

It's Fedora 39/GNOME 45 inside GNOME Boxes.

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

Looks like I can't repro on my host running F40

This comment needs to be solved #5261 (comment)

@eclipseo
Copy link
Author

Ok I removed the flathub.json

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 19, 2024
@barthalion
Copy link
Member

bot, build org.fooyin.fooyin

@flathubbot
Copy link

Queued test build for org.fooyin.fooyin.

@flathubbot
Copy link

Started test build 122400

@flathubbot
Copy link

Build 122400 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105341/org.fooyin.fooyin.flatpakref

@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/org.fooyin.fooyin

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 21, 2024
@eclipseo
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants