Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in.co.nandakumar.vara #5265

Closed
wants to merge 3 commits into from

Conversation

nandedamana
Copy link

Please confirm your submission meets all the criteria

  • Please describe your application briefly.
  • I have read the App Requirements and App Maintenance pages.
  • My pull request follows the instructions at App Submission.
  • I have built and tested the submission locally.
  • I am using only the minimal set of permissions. (Using filesystem=host since the users are supposed to be able to persist their work and export to the local filesystm)
  • All assets referenced in the manifest are redistributable by any party. If not, the unredistributable parts are using an extra-data source type.
  • I am the author/developer/upstream contributor of the project.
  • The domain used for the application ID is controlled by the application developers either directly or through the code hosting (e.g. GitHub, GitLab, SourceForge, etc.). The application id guidelines are followed.
  • Any additional patches or files have been submitted to the upstream projects concerned.

@nandedamana
Copy link
Author

Update: I missed the description part:

Drawing and digital painting application with pressure-sensitive brushes. Works on GNU/Linux and Windows.

Vara is not an image editor, unlike GIMP or Photoshop. It probably isn't a kindergarten drawing program either, unlike TuxPaint. It belongs to the group of drawing applications like Krita and MyPaint, but with a limited number of features.

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

The readme says:

Licensing info

I plan to release this program and its source code under some Libre/Open Source
license. Until then, it remains proprietary, but you are free to use this
version of the program for any purpose and to share its verbatim copies with
anybody you want, to the extent permitted by law.

But it's marked as GPL-3.0 in the metainfo file. It's definitely not proprietary anymore since you made the source available. You might want to update that.

- --socket=fallback-x11
- --socket=wayland
- --share=ipc
- --filesystem=host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need host?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help users save the file wherevery they want. Is there another way to do it? I'd spent at least half an hour going through the doc and doing some experiments before adding this hesitantly. I'd be happy to make changes if there is a better way.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If your app uses filechooser portal https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.FileChooser.html and opening and saving goes through a filepicker you don't need any access

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is gtk3, so that involves using Gtkfilechoosernative https://docs.gtk.org/gtk3/class.FileChooserNative.html which uses portal by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we wait for this to be implemented?

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

bot, build in.co.nandakumar.vara

@flathubbot
Copy link

Queued test build for in.co.nandakumar.vara.

@flathubbot
Copy link

Started test build 121909

@bbhtt bbhtt added the awaiting-changes Pull request waiting for changes from author label May 19, 2024
@flathubbot
Copy link

Build 121909 failed

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

@nandedamana
Copy link
Author

The readme says:

Licensing info

I plan to release this program and its source code under some Libre/Open Source
license. Until then, it remains proprietary, but you are free to use this
version of the program for any purpose and to share its verbatim copies with
anybody you want, to the extent permitted by law.

But it's marked as GPL-3.0 in the metainfo file. It's definitely not proprietary anymore since you made the source available. You might want to update that.

Thanks, I've updated it.

@nandedamana
Copy link
Author

nandedamana commented May 19, 2024

Metainfo is missing release https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#release and OARS tag https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#oars-information

Thanks for the links. I'll fix them. BTW, why didn't the validations steps in https://docs.flathub.org/docs/for-app-authors/submission/ reveal these issues?

EDIT: I think it warned me about the missing rating, not release though.

@bbhtt
Copy link
Contributor

bbhtt commented May 19, 2024

bot, build in.co.nandakumar.vara

@flathubbot
Copy link

Queued test build for in.co.nandakumar.vara.

@flathubbot
Copy link

Started test build 121956

@flathubbot
Copy link

Build 121956 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/104900/in.co.nandakumar.vara.flatpakref

about-dialog-icon.patch Outdated Show resolved Hide resolved
@nandedamana
Copy link
Author

@bbhtt anything remaining to be done from my part (other than the migration to Portals, which I do not plan to do in the current version as long as it is okay)?

@bbhtt
Copy link
Contributor

bbhtt commented May 22, 2024

which I do not plan to do in the current version as long as it is okay)?

Ok sure.

bot, build in.co.nandakumar.vara

@flathubbot
Copy link

Queued test build for in.co.nandakumar.vara.

@flathubbot
Copy link

Started test build 122711

@flathubbot
Copy link

Build 122711 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/105652/in.co.nandakumar.vara.flatpakref

@bbhtt bbhtt added ready Pull request ready for final review and merge and removed awaiting-changes Pull request waiting for changes from author labels May 22, 2024
@barthalion
Copy link
Member

/merge

@flathubbot
Copy link

A repository for this submission has been created: https://github.com/flathub/in.co.nandakumar.vara

You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here.

If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you.

Thanks!

@flathubbot flathubbot closed this May 24, 2024
@nandedamana
Copy link
Author

@bbhtt @hfiguiere @barthalion Thanks a lot for your help in getting Vara into Flathub. Unfortunately, due to this issue (duplicate of this one), I'm not able to auto-verify my application. Can I get it manually verified? I've placed the required file in the required path in my website.

@bbhtt
Copy link
Contributor

bbhtt commented May 25, 2024

We generally don't interfere with verification. If it is manually verified it will say "verified by Flathub team" in the tooltip instead of your website, so it is best not to.

You will have to wait until that issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request ready for final review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants