-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in.co.nandakumar.vara #5265
Conversation
Update: I missed the description part: Drawing and digital painting application with pressure-sensitive brushes. Works on GNU/Linux and Windows. Vara is not an image editor, unlike GIMP or Photoshop. It probably isn't a kindergarten drawing program either, unlike TuxPaint. It belongs to the group of drawing applications like Krita and MyPaint, but with a limited number of features. |
The readme says:
But it's marked as GPL-3.0 in the metainfo file. It's definitely not proprietary anymore since you made the source available. You might want to update that. |
- --socket=fallback-x11 | ||
- --socket=wayland | ||
- --share=ipc | ||
- --filesystem=host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need host?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To help users save the file wherevery they want. Is there another way to do it? I'd spent at least half an hour going through the doc and doing some experiments before adding this hesitantly. I'd be happy to make changes if there is a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If your app uses filechooser portal https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.FileChooser.html and opening and saving goes through a filepicker you don't need any access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it is gtk3, so that involves using Gtkfilechoosernative https://docs.gtk.org/gtk3/class.FileChooserNative.html which uses portal by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we wait for this to be implemented?
bot, build in.co.nandakumar.vara |
Queued test build for in.co.nandakumar.vara. |
Started test build 121909 |
Build 121909 failed |
Metainfo is missing release https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#release and OARS tag https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/#oars-information |
Thanks, I've updated it. |
Thanks for the links. I'll fix them. BTW, why didn't the validations steps in https://docs.flathub.org/docs/for-app-authors/submission/ reveal these issues? EDIT: I think it warned me about the missing rating, not release though. |
…o appstream metainfo
bot, build in.co.nandakumar.vara |
Queued test build for in.co.nandakumar.vara. |
Started test build 121956 |
Build 121956 successful
|
@bbhtt anything remaining to be done from my part (other than the migration to Portals, which I do not plan to do in the current version as long as it is okay)? |
Ok sure. bot, build in.co.nandakumar.vara |
Queued test build for in.co.nandakumar.vara. |
Started test build 122711 |
Build 122711 successful
|
/merge |
A repository for this submission has been created: https://github.com/flathub/in.co.nandakumar.vara You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you. Thanks! |
@bbhtt @hfiguiere @barthalion Thanks a lot for your help in getting Vara into Flathub. Unfortunately, due to this issue (duplicate of this one), I'm not able to auto-verify my application. Can I get it manually verified? I've placed the required file in the required path in my website. |
We generally don't interfere with verification. If it is manually verified it will say "verified by Flathub team" in the tooltip instead of your website, so it is best not to. You will have to wait until that issue is resolved. |
Please confirm your submission meets all the criteria