Skip to content

Commit

Permalink
Remove Redis read/write timeouts (#943)
Browse files Browse the repository at this point in the history
If no results were sent over the pubsub channel, the client would hang
up. This would cause the query to seem "hung".

Closes #911
  • Loading branch information
zwass committed Jun 3, 2021
1 parent bf37cb9 commit 6f51bd9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions server/pubsub/redis_query_results.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ func NewRedisPool(server, password string, database int, useTLS bool) *redis.Poo
redis.DialDatabase(database),
redis.DialUseTLS(useTLS),
redis.DialConnectTimeout(5*time.Second),
redis.DialReadTimeout(5*time.Second),
redis.DialWriteTimeout(5*time.Second),
redis.DialKeepAlive(5*time.Second),
redis.DialKeepAlive(10*time.Second),
// Read/Write timeouts not set here because we may see results
// only rarely on the pub/sub channel.
)

if err != nil {
Expand Down

0 comments on commit 6f51bd9

Please sign in to comment.