Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoveltySlice help page references image that isn't there #426

Open
MattS6464 opened this issue Aug 25, 2023 · 3 comments
Open

NoveltySlice help page references image that isn't there #426

MattS6464 opened this issue Aug 25, 2023 · 3 comments

Comments

@MattS6464
Copy link
Contributor

NoveltySlice help page states:

"Below is a depiction of a novelty curve, computed on the self-similarity matrix you can see above with a kernel size of 41. The detected peaks (read slice points) that come out of this are marked in red."

There are no images below this text.

@jamesb93
Copy link
Member

jamesb93 commented Sep 3, 2023

I wrote this file, so I am sure that two things could have happened.

  • I planned to put something in the <NoveltyCurve/> component and forgot or never got time to do it
  • I did and it got mangled by git.

I checked through the history of that file and I was unable to see any meaningful content in that component.

I'd suggest two paths forward:

  1. Edit the text so that it no longer appears in the rendered HTML, close this issue and then create a new issue that tracks the creation of a new component. @fearn-e you might be interested in doing some of this work.
  2. Fix it all in one go by creating a component that does what I said it did.

@MattS6464
Copy link
Contributor Author

@jamesb93 ,from where I've just looked, in learn-website/src/routes/(content)/reference/noveltyslice there is a NoveltyCurve.svelte but the file is completely empty. I assume this is the file being included in line 33 of +page.svx (under the same file path).

The ssm image is working in the reference file, and in learn-website/static/reference/noveltyslice there's an ssm.json and ssm.svg but only a curve.json with no curve.svg.
Could this have caused the issue? I'm not too familiar with these files so I thought it best to ask before committing to either of your solutions.

@jamesb93
Copy link
Member

Yes exactly. The component (NoveltyCurve.svelte is referred to as a component) is empty, for some reason I can't recall. It certainly was always empty as I checked in the git history so I imagine I planned to put something in at some point but never got around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants