fix: add warning to document.get since it doesn't match dict.get and make more robust #26279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
casesolved-co-uk
force-pushed
the
doc_get
branch
2 times, most recently
from
24e3c25
to
f59cbd6
Compare
|
Due to the sheer number of warnings in the tests, the function default clearly needs to be changed to match dict.get() So you would need to refactor all calls that need the See #26281 |
casesolved-co-uk
force-pushed
the
doc_get
branch
5 times, most recently
from
52f399c
to
1b57f41
Compare
|
ig the other PR is supposed to be merged (?) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very easy to mistake document.get for python dict.get or frappe _dict.get but they have very different usage:
document.get(key, filters=None, limit=None, default=None)dict.get(key[, default])Potential fix / illustration for #26280
version-14-hotfix
version-15-hotfix