Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: new and add child button for empty tree doctype #26328

Merged
merged 3 commits into from
May 13, 2024
Merged

fix: new and add child button for empty tree doctype #26328

merged 3 commits into from
May 13, 2024

Conversation

rutwikhdev
Copy link
Contributor

@rutwikhdev rutwikhdev commented May 6, 2024 •
edited

Fixes:
#26158
#26414

Steps to reproduce:

  • Enable is_root on any doctype that doesn't have any records
  • Try to create root node either with "Add Child" or "New"

no-docs

@rutwikhdev
fix: new and add child button for empty tree doctype
3b89c3f 
- The second check in treeview.js is useless
- If the node being created is root-node(i.e. doctype(name) is parent
  then don't set parent)
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 6, 2024
@rutwikhdev rutwikhdev marked this pull request as ready for review May 7, 2024 05:49
@rutwikhdev rutwikhdev requested a review from a team as a code owner May 7, 2024 05:49
@rutwikhdev rutwikhdev requested review from akhilnarang and removed request for a team May 7, 2024 05:49
This was linked to issues May 13, 2024
In Tree view "New" button doesn't work #26158
Closed
(Tree View): Show title for Root Node #26414
Closed
@rutwikhdev rutwikhdev added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 and removed add-test-cases Add test case to validate fix or enhancement labels May 13, 2024
@rutwikhdev rutwikhdev merged commit 35f0d92 into frappe:develop May 13, 2024
24 checks passed
@rutwikhdev rutwikhdev added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 and removed backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels May 13, 2024
This was referenced May 20, 2024
Closed
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akhilnarang akhilnarang Awaiting requested review from akhilnarang akhilnarang is a code owner automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Tree View): Show title for Root Node In Tree view "New" button doesn't work
1 participant
@rutwikhdev