Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated custom Containerfile to solve custom app download issue #1345

Closed
wants to merge 1 commit into from

Conversation

malay-gondalia
Copy link
Contributor

Updated custom Containerfile to solve custom app download issue as there was error downloading custom apps from user git

Please provide enough information so that others can review your pull request:
was unable to download apps from my git repo. added code to loop through app variable to download.

Explain the details for making this change. What existing problem does the pull request solve?

added code to download apps from user git if not found.

Updated custom Containerfile to solve custom app download issue as there was error downloading custom apps from user git
@revant
Copy link
Collaborator

revant commented Mar 1, 2024

If you pass the PAT or credentials properly in apps.json it should work.

For your custom case you can always use your fork.

I managed to render apps.json with pat/creds using jinja and env var. If that is passed and is correct the it should work.

Try correct apps.json and try bench init manually on devcontainer

Copy link
Contributor

github-actions bot commented May 1, 2024

This PR has been automatically marked as stale. You have a week to explain why you believe this is an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants