Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loan collateral #106

Closed
wants to merge 5 commits into from
Closed

feat: loan collateral #106

wants to merge 5 commits into from

Conversation

anandbaburajan
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #106 (e093ebc) into develop (4b7ef98) will increase coverage by 0.17%.
Report is 11 commits behind head on develop.
The diff coverage is 53.12%.

@@             Coverage Diff             @@
##           develop     #106      +/-   ##
===========================================
+ Coverage    48.01%   48.19%   +0.17%     
===========================================
  Files           50       56       +6     
  Lines         2770     2984     +214     
===========================================
+ Hits          1330     1438     +108     
- Misses        1440     1546     +106     
Files Coverage Δ
lending/install.py 0.00% <ø> (ø)
..._loan_securities/top_10_pledged_loan_securities.py 0.00% <ø> (ø)
...eral/loan_collateral_assignment_loan_collateral.py 100.00% <100.00%> (ø)
...al/loan_collateral_deassignment_loan_collateral.py 100.00% <100.00%> (ø)
...an_disbursement_charge/loan_disbursement_charge.py 100.00% <100.00%> (ø)
...anagement/doctype/loan_repayment/loan_repayment.py 62.19% <100.00%> (+0.23%) ⬆️
..._exposure/applicant_wise_loan_security_exposure.py 0.00% <ø> (ø)
...eport/loan_interest_report/loan_interest_report.py 0.00% <ø> (ø)
...d_party_owner/loan_collateral_third_party_owner.py 0.00% <0.00%> (ø)
...an_management/doctype/loan_product/loan_product.py 79.31% <72.72%> (-4.03%) ⬇️
... and 9 more

@anandbaburajan
Copy link
Contributor Author

@mergify copy poc-staging

@mergify
Copy link

mergify bot commented Oct 19, 2023

copy poc-staging

✅ Pull request copies have been created

@bosue

This comment was marked as outdated.

@anandbaburajan
Copy link
Contributor Author

a single database / table of securities (including collaterals) might be more flexible.

Yes, and we're experimenting. #108 is the final one.

@bosue
Copy link
Contributor

bosue commented Oct 20, 2023

@anandbaburajan I‘m sorry. Experimenting is wonderful, enjoy!
I guess I should leave you alone for a while, doing your thing with lending.
Result is gonna be good, but on the way, my comments are not going to help… 🤷🏻‍♂️

@anandbaburajan
Copy link
Contributor Author

@bosue please don't be sorry; the comments do help most of the time. Feel free to ask questions and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants