Skip to content

Commit

Permalink
fix(wiki-page): clear cache after updating page settings
Browse files Browse the repository at this point in the history
  • Loading branch information
BreadGenie committed Apr 16, 2024
1 parent 3f12cdd commit 2e33fc9
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions wiki/wiki/doctype/wiki_page/wiki_page.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def before_save(self):

if old_title := frappe.db.get_value("Wiki Page", self.name, "title"):
if old_title != self.title:
self.clear_sidebar_cache()
clear_sidebar_cache()

def after_insert(self):
frappe.cache().hdel("website_page", self.name)
Expand All @@ -49,10 +49,6 @@ def after_insert(self):
def on_update(self):
update_index(self)

def clear_sidebar_cache(self):
for key in frappe.cache().hgetall("wiki_sidebar").keys():
frappe.cache().hdel("wiki_sidebar", key)

def on_trash(self):

frappe.db.sql("DELETE FROM `tabWiki Page Revision Item` WHERE wiki_page = %s", self.name)
Expand Down Expand Up @@ -80,7 +76,7 @@ def on_trash(self):
wiki_sidebar_name = frappe.get_value("Wiki Group Item", {"wiki_page": self.name})
frappe.delete_doc("Wiki Group Item", wiki_sidebar_name)

self.clear_sidebar_cache()
clear_sidebar_cache()
remove_index(self)

def sanitize_html(self):
Expand Down Expand Up @@ -405,6 +401,11 @@ def get_open_drafts():
return f'<span class="count">{count}</span>'


def clear_sidebar_cache():
for key in frappe.cache.hgetall("wiki_sidebar").keys():
frappe.cache.hdel("wiki_sidebar", key)


@frappe.whitelist()
def preview(original_code, new_code, name):
from lxml.html.diff import htmldiff
Expand Down Expand Up @@ -592,6 +593,7 @@ def update_page_settings(name, settings):
from frappe.utils import sbool

frappe.has_permission(doctype="Wiki Page", ptype="write", doc=name, throw=True)
clear_sidebar_cache()
settings = frappe.parse_json(settings)

frappe.db.set_value(
Expand Down

0 comments on commit 2e33fc9

Please sign in to comment.