-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add meta tags for Wiki Page #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, perhaps these should have UI too? 👁️
relevant code: https://github.com/frappe/frappe/blob/develop/frappe/templates/includes/meta_block.html
UI for meta tags? I didn't get you 😅 |
Wiki is meant to be used from its frontend using "wiki page patches" and not the Desk interface. Though this is just meta info that not everyone understands or needs to edit. |
Yeah I wasn't able to connect fields in the frontend editor with the doctype 😄 |
merging as is for now. If someone cares about modifying this from client side, feel free to send PR. 😬 TBH I was thinking of UI rewrite to use frappe-ui so this will be easier in future. jquery + HTML attribute based state management is so '00s 😩 |
I thought of recreating the entire Wiki/Docs app using a modern frontend tool. Problem with making a SPA however is that it sucks for SEO - something that a documentation tool definitely needs. I'm looking into SSR, or even SSG for that matter, to create a documentation site with a Frappe backend. (Probably NextJS, or Remix) Some of the features I am thinking of:
Most documentation sites can actually be statically served (especially public ones) - so they can be generated during build time. Obviously in our case, we would use Frappe as a CMS - so it would be built everytime the content is updated. Or we could just use SSR for it, but that's a little unnecessary for docs. Let me know if you have any more ideas about this. In the meantime, can someone give me access to the Wiki module of the Frappe documentation so that I can add these keywords? None of the pages actually show up on Google 😅 |
We are using vitepress for our own books and insights documentation 🙈 It is quite good, you may want to give it a try. |
Sure, you can add something and send an approval request, we will give you auto-approve then. |
Maybe we can build Next-gen frappe wiki on vitepress 😅 |
This PR adds the following meta tags in every Wiki page:
Hopefully doing this will now allow us to find documentation from Google by improving page rankings.
I wasn't able to figure out how to add these fields in the web page editor. Maybe someone can help me with that.
#97 should be partially done with this.