Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEP-24] Manage Gardener Discovery Server via Gardener Operator #9746

Merged
merged 15 commits into from
May 27, 2024

Conversation

dimityrmirchev
Copy link
Member

@dimityrmirchev dimityrmirchev commented May 14, 2024

How to categorize this PR?

/area security
/kind enhancement

What this PR does / why we need it:
This PR enables the gardener-operator to install https://github.com/gardener/gardener-discovery-server. The PR can be reviewed but will remain a draft until v0.1.0 of the discovery server is released.

/cc @vpnachev

cc @rfranzke @timuthy in case you have the capacity to review

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`gardener-operator` is now able to manage `gardener-discovery-server`. For details, please check the [Discovery Server](https://github.com/gardener/gardener/blob/master/docs/concepts/operator.md#gardener-discovery-server) configuration section.
Users can now enable managed service account issuers for their shoots if the Gardener installation has this capability enabled. For details, please check the [Managed Service Account Issuer](https://github.com/gardener/gardener/blob/master/docs/usage/shoot_serviceaccounts.md#managed-service-account-issuer) documentation.

@gardener-prow gardener-prow bot requested a review from vpnachev May 14, 2024 08:37
@gardener-prow gardener-prow bot added area/security Security related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 14, 2024
@dimityrmirchev
Copy link
Member Author

/area ipcei

@gardener-prow gardener-prow bot added the area/ipcei IPCEI (Important Project of Common European Interest) label May 14, 2024
@rfranzke
Copy link
Member

/assign

@dimityrmirchev
Copy link
Member Author

Can be reviewed but do not merge until https://github.com/gardener/gardener-discovery-server has a v0.1.0 version.
/hold

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2024
Copy link
Member

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good, I have some minor nits in-line.

@vpnachev
Copy link
Member

/lgtm
/retest-required

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
docs/concepts/operator.md Outdated Show resolved Hide resolved
docs/concepts/operator.md Outdated Show resolved Hide resolved
docs/concepts/operator.md Outdated Show resolved Hide resolved
docs/concepts/operator.md Outdated Show resolved Hide resolved
docs/concepts/operator.md Outdated Show resolved Hide resolved
pkg/component/gardener/discoveryserver/discoveryserver.go Outdated Show resolved Hide resolved
pkg/component/gardener/discoveryserver/discoveryserver.go Outdated Show resolved Hide resolved
pkg/component/gardener/discoveryserver/deployment.go Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@gardener-prow gardener-prow bot requested review from rfranzke and vpnachev May 21, 2024 12:14
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@JordanJordanov JordanJordanov added the ipcei/oidc Epic for Gardener OIDC scenarios label May 22, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2024
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good as such now, thanks a lot for the iteration. Waiting for the image release now :)

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link
Contributor

gardener-prow bot commented May 27, 2024

LGTM label has been added.

Git tree hash: c92b65c3e287fd851fb2ca93bad866d17e8992ec

Copy link
Contributor

gardener-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@dimityrmirchev
Copy link
Member Author

/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2024
@dimityrmirchev
Copy link
Member Author

/test pull-gardener-e2e-kind

@gardener-prow gardener-prow bot merged commit dfae578 into gardener:master May 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/oidc Epic for Gardener OIDC scenarios kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants