-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-24] Manage Gardener Discovery Server via Gardener Operator #9746
[GEP-24] Manage Gardener Discovery Server via Gardener Operator #9746
Conversation
/area ipcei |
/assign |
Can be reviewed but do not merge until https://github.com/gardener/gardener-discovery-server has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good, I have some minor nits in-line.
/lgtm |
e1e2947
to
0436581
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good as such now, thanks a lot for the iteration. Waiting for the image release now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: c92b65c3e287fd851fb2ca93bad866d17e8992ec
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/test pull-gardener-e2e-kind |
How to categorize this PR?
/area security
/kind enhancement
What this PR does / why we need it:
This PR enables the
gardener-operator
to install https://github.com/gardener/gardener-discovery-server. The PR can be reviewed but will remain a draft untilv0.1.0
of the discovery server is released./cc @vpnachev
cc @rfranzke @timuthy in case you have the capacity to review
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
`gardener-operator` is now able to manage `gardener-discovery-server`. For details, please check the [Discovery Server](https://github.com/gardener/gardener/blob/master/docs/concepts/operator.md#gardener-discovery-server) configuration section.
Users can now enable managed service account issuers for their shoots if the Gardener installation has this capability enabled. For details, please check the [Managed Service Account Issuer](https://github.com/gardener/gardener/blob/master/docs/usage/shoot_serviceaccounts.md#managed-service-account-issuer) documentation.