dev-python/jupyterlab_widgets: add new package #36723
Conversation
Pull Request assignmentSubmitter: @efferre79 dev-python/ipywidgets: @gentoo/sci, @gentoo/python Linked bugsMissing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
new package
Pull request CI reportReport generated at: 2024-05-17 16:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| >=dev-python/ipython_genutils-0.2.0[${PYTHON_USEDEP}] | ||
| >=dev-python/traitlets-4.3.1[${PYTHON_USEDEP}] | ||
| >=dev-python/widgetsnbextension-4.0.10[${PYTHON_USEDEP}] | ||
| >=dev-python/jupyterlab_widgets-3.0.10[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
Shouldn't this be an optional dependency?
There was a problem hiding this comment.
Do you mean that on dev-python/jupyterlab_widgets? It is the same as for dev-python/widgetsnbextension which is the legacy way, latest jupyter requires dev-python/jupyterlab_widgets, see the docs. Right now ipywidgets disables jupyterlab_widgets because the package is not in portage, the result is that the widgets are not available in the browser
There was a problem hiding this comment.
I see, then we'll indeed have to revbump and add it as required.
|
|
||
| LICENSE="BSD" | ||
| SLOT="0" | ||
| KEYWORDS="amd64 arm arm64 ~loong ppc64 ~riscv x86 ~amd64-linux ~x86-linux" |
There was a problem hiding this comment.
Please add only keywords that you have tested the package on (and only unstable keywords)
There was a problem hiding this comment.
We'll have to drop these keywords in ipywidgets.ebuild as well.
| PYTHON_COMPAT=( pypy3 python3_{10..12} ) | ||
| PYTHON_REQ_USE="threads(+)" | ||
|
|
||
| inherit distutils-r1 pypi |
There was a problem hiding this comment.
What about using the github tarballs instead, they have tests. Would this work?
There was a problem hiding this comment.
I have copied and adapted the ebuild from widgetsnbextension
|
@AndrewAmmerlaan I have created now two atomic commits with a signed-off-by line, one for jupyterlab_widgets and the other for a new ebuild release of ipywidgets. |
| KEYWORDS="~amd64 ~x86" | ||
|
|
||
| BDEPEND=" | ||
| dev-python/jupyter-packaging[${PYTHON_USEDEP}] |
There was a problem hiding this comment.
This should also depend on jupyterlab according to pyproject.toml
Thanks, could you squash the older commits into the new commits so we have only the two commits we need here? |
Bug: https://bugs.gentoo.org/932031 Signed-off-by: Fabio Rossi <rossi.f@inwind.it>
jupyerlab_widgets is needed for latest notebook version Bug: https://bugs.gentoo.org/932075 Signed-off-by: Fabio Rossi <fabio.rossi@elettra.eu>
efferre79
force-pushed
the
jupyterlab_widgtes
branch
from
b678d25
to
61e7653
Compare
Pull request CI reportReport generated at: 2024-05-20 16:45 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Thanks, I resolved the QA complaint, the new package needed masking on amd64 - x32. |
This would solve
https://bugs.gentoo.org/show_bug.cgi?id=932031
https://bugs.gentoo.org/show_bug.cgi?id=932075.
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.