Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ebuilds i made and a version bump(lux, pamixer, and version bump… #167

Closed
wants to merge 1 commit into from

Conversation

oblivikun
Copy link

… nuclear-bin)

@MrRoy
Copy link
Contributor

MrRoy commented Apr 25, 2024

Please follow the Gentoo git workflow & Copyright Policy

Particularly:

  • Atomicity
  • Commit message format
  • Sign-off your commit

@MrRoy
Copy link
Contributor

MrRoy commented May 13, 2024

Hi @oblivikun,

Do you still want this to be merged?
If so please review my above comment
In short;

  • Your commits need to be split up (one commit per package affected)
  • Your commit messages should indicate which packages are being touched
  • Your commits need to be signed off (using git commit --signoff)

@oblivikun
Copy link
Author

I am so sorry i dont read my github notifications alot. Is this good?

@oblivikun
Copy link
Author

added oksh

@MrRoy
Copy link
Contributor

MrRoy commented May 21, 2024

Hi @oblivikun,

You have two commits which aren't signed-off, can you please sign them off? Afterwards I'll be able to merge this

…r manifest so thats added now

Signed-off-by: Erel Bitzan <dudepog8@gmail.com>
Signed-off-by: oblivikun <dudepog8@gmail.com>
@oblivikun
Copy link
Author

oh uh oops(i cannot use git im so sorry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants