dev-util/hut: version bump to 0.5.0 #191
Conversation
|
As of yesterday, according to https://git.sr.ht/~emersion/hut, the maintainer and repo for hut has changed owner. It is now here: https://git.sr.ht/~xenrox/hut Since there are no new releases, I don't think this PR should change. |
There was a problem hiding this comment.
As of yesterday, according to https://git.sr.ht/~emersion/hut, the maintainer and repo for hut has changed owner. It is now here: https://git.sr.ht/~xenrox/hut
Since there are no new releases, I don't think this PR should change.
Since the upstream information in metadata.xml now needs changing, I suggest you tackle both that and this ebuild at once, so that they are up to date and in sync :)
Changes for metadata.xml:
- Remove
<remote-id type="github">apraga/hut-vendor</remote-id>
It's not related to upstream. - Update
<remote-id type="sourcehut">~emersion/hut</remote-id>to reflect the new upstream.
Thank you for bumping this package!
| @@ -21,7 +21,6 @@ SLOT="0" | |||
|
|
|||
| KEYWORDS="~amd64" | |||
|
|
|||
|
|
|||
| DEPEND="${RDEPEND}" | |||
| BDEPEND="app-text/scdoc" | |||
There was a problem hiding this comment.
Manpages that require additional deps to be built, should be shipped alongside the package: https://projects.gentoo.org/qa/policy-guide/installed-files.html#pg0305
Could you do that and drop the BDEPEND, please?
There was a problem hiding this comment.
This is incorrect. The policy states that:
USE=manmust not be used, since the package must always install a manpage- prebuilding it and shipping it as an additional source is a good alternative to requiring "inconvenient" additional dependencies
scdoc isn't an inconvenient additional dependency. I don't think it's necessary to prebuild it, as the package currently doesn't violate the policy document.
There was a problem hiding this comment.
@eli-schwartz It seems I misunderstood part of the policy. Your second bullet point clarified it for me, thanks!
dev-util/hut/hut-0.5.0.ebuild
Outdated
| @@ -21,7 +21,6 @@ SLOT="0" | |||
|
|
|||
| KEYWORDS="~amd64" | |||
|
|
|||
|
|
|||
| DEPEND="${RDEPEND}" | |||
There was a problem hiding this comment.
Delete this line, since both RDEPEND and DEPEND are empty.
dev-util/hut/hut-0.5.0.ebuild
Outdated
| @@ -11,7 +11,7 @@ HOMEPAGE="https://sr.ht/~emersion/hut/" | |||
|
|
|||
| SRC_URI=" | |||
| https://git.sr.ht/~emersion/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz | |||
There was a problem hiding this comment.
Please update this to reflect the upstream change.
There was a problem hiding this comment.
- Fix the copyright, please.
The package was introduced to ::guru last year and it should read2023-2024. - Update
HOMEPAGEto reflect the upstream change. - If you decide to ship a pre-built manpage, remove the
doc/hut.1target insrc_compileand install the file insrc_install.
also tidy up the ebuild: * upstream changed, see the notice in the old upstream's README: https://git.sr.ht/~emersion/hut * correct the copyright years * drop 'DEPEND="${RDEPEND}"' Signed-off-by: Christopher Bayliss <cjbdev@icloud.com>
|
Thank you for the review!! ❤️ I tried dropping the dependency on Then they suggested that depending on If you insist on it, I'll drop |
|
LGTM, merged in 027c1e5 |
No description provided.