Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-mathematics/Oid: Fix java, update URLs #1240

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

APN-Pucky
Copy link
Contributor

This concludes my quick check of the sci-mathematics packages. Only sci-mathematics/frama still fails and I know nothing about ocaml.

Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
sci-mathematics/Oid/Oid-4.0-r1.ebuild Outdated Show resolved Hide resolved
}

src_install () {
jar cef Oid Oid.jar -C classes . || die "Failed to create jar"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with java packaging, but I believe there is some function in the eclasses to do this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super familiar with java packaging, but I believe there is some function in the eclasses to do this.

java-pkg-simple.eclass is the eclass I was thinking of before. I think it should make most of the explicit phase declarations above unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it has a similar call in src_compile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to just drop the custom compile https://gitlab.com/APN-Pucky/gentoo-sci/-/merge_requests/44/diffs, but then it does not compile anymore. I haven't looked at it much/in detail yet.

Co-authored-by: Andrew Nowa Ammerlaan <andrewammerlaan@gentoo.org>
@APN-Pucky APN-Pucky marked this pull request as draft April 21, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants