Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat concurrent chunk data #1398

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shaohk
Copy link
Contributor

@shaohk shaohk commented Mar 15, 2024

Description

This PR Supports concurrent copying of chunk blocks during each time slice of copying the existing data.

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@shaohk
Copy link
Contributor Author

shaohk commented Mar 19, 2024

MySQL insert ... select ... does not permit concurrent.

https://dev.mysql.com/doc/refman/5.7/en/insert-select.html

@shaohk shaohk closed this Mar 19, 2024
@shaohk
Copy link
Contributor Author

shaohk commented Mar 20, 2024

When the unique index used for copying blocks includes an auto-increment column, concurrency is blocked on the auto-inc lock. If the unique index used does not include an auto-increment column, concurrency can proceed.

@shaohk shaohk reopened this Mar 20, 2024
@shaohk shaohk changed the title Feat parallel chunk data feat concurrent chunk data Mar 20, 2024
@ramshad-sha ramshad-sha mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant