feat: Avoid API Rate-Limiting #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this one locally and running into issues that also happen on the main branch. Will continue trying to figure out what's going on so I can see this in action. |
|
Still working on this, Thanks for hanging in there. I'm currently trying to rule out what is causing the issue and then doing local reruns. |
zkoppert
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Rate limiting of the Github search API is causing a 403 Authentication Error for some users. Issues #217 and potentially #166 are related.
Proposed Changes
The github3 SearchIterator object has a ratelimit_remaining property that is used to measure if we are near API rate limits. If remaining requests are low (<5), there is a 1 minute delay to refresh requests with exponential increases in delays (corresponding rate limit docs). This is consistent with Github's recommended best practice guidelines since the github3 wrappers prevent us from easily accessing the retry headers.
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking