Conversion to System.Text.Json
#1209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quickly merged master into this, but haven't tested the new version; is there any interest in this in general though? |
|
Technically yes, but it's a bit hard to justify since there could be a lot of subtle bugs here and no huge benefits. You should leave this open as a memorial to what could be, if I have the time some day. |
|
Yeah you are probably right, this does make more sense on modern .NET anyways |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes and replaces Newtonsoft.Json
Everything should be functionally equivalent, except for
Headlinesdeserialization, which works, but is not a 1:1 translation of the old options.The remote patcher RPC has been slightly reworked to allow for deserialization without type information as well.