Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional link for sboms #20423

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

stonezdj
Copy link
Contributor

artifact object's addition_links has sboms item when it support to generate sbom
fixes #20346

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.35%. Comparing base (b7b8847) to head (42d5cad).
Report is 188 commits behind head on main.

❗ Current head 42d5cad differs from pull request most recent head e81076b. Consider uploading reports for the commit e81076b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20423       +/-   ##
===========================================
- Coverage   67.56%   46.35%   -21.21%     
===========================================
  Files         991      247      -744     
  Lines      109181    13749    -95432     
  Branches     2719     2830      +111     
===========================================
- Hits        73768     6374    -67394     
+ Misses      31449     7052    -24397     
+ Partials     3964      323     -3641     
Flag Coverage Δ
unittests 46.35% <ø> (-21.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

Copy link
Contributor

@zyyw zyyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR may need to be rebased after this PR is merged into main.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

  artifact object's addition_links has sboms item when it support to generate sbom
  fixes goharbor#20346

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj merged commit 2b4fe6c into goharbor:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should this be Unsupported either for SBOM?
5 participants