Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lapack: add Dtgsy2/Dtgsyl and tests #1891

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

soypat
Copy link
Contributor

@soypat soypat commented Sep 5, 2023

Part of #1651

This PR candidate replaces #1886 and #1741.

Notice lapack package LocalLookAhead MaximizeNormXJob has been changed from 0 to 1 to better match Dlatdf's caller convention Dtgsy2.

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2023

Codecov Report

Patch coverage: 75.76% and project coverage change: +0.11% 🎉

Comparison is base (93223b4) 74.00% compared to head (d98e9cf) 74.11%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   74.00%   74.11%   +0.11%     
==========================================
  Files         526      528       +2     
  Lines       63210    63828     +618     
==========================================
+ Hits        46778    47307     +529     
- Misses      13854    13915      +61     
- Partials     2578     2606      +28     
Files Changed Coverage Δ
lapack/gonum/dtgsyl.go 57.14% <57.14%> (ø)
lapack/gonum/dtgsy2.go 83.48% <83.48%> (ø)
lapack/gonum/ilaenv.go 43.40% <100.00%> (+1.38%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants