Fix vcmul microkernel tester #6430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_634416194
branch
2 times, most recently
from
b7fd0c1
to
a26ebeb
Compare
fbarchard
approved these changes
May 16, 2024
copybara-service
bot
force-pushed
the
test_634416194
branch
from
a26ebeb
to
82dc491
Compare
The tester was using `nanf("")` to initialize the output buffer, but this is not a valid `NaN` value for fp16. This CL changes the tester to use `UINT16_C(0x7E00)`, which is a valid `NaN` value for `fp16`.
PiperOrigin-RevId: 634504596
copybara-service
bot
force-pushed
the
test_634416194
branch
from
82dc491
to
f79f872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix vcmul microkernel tester
The tester was using
nanf("")to initialize the output buffer, but this is not a validNaNvalue for fp16. This CL changes the tester to useUINT16_C(0x7E00), which is a validNaNvalue forfp16.