Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[export] Relax the check that exported modules are used with same number of devices as when exported #21280

Merged
merged 1 commit into from
May 21, 2024

Conversation

gnecula
Copy link
Collaborator

@gnecula gnecula commented May 17, 2024

Now we allow a module exported for 1 device and not using any sharding annotations to be called from a computation that uses multiple devices. Such exported modules can be parallelized trivially point-wise.

This is an attempt to re-land #21203 after internal test failures.

@gnecula gnecula self-assigned this May 17, 2024
@gnecula gnecula added the pull ready Ready for copybara import and testing label May 17, 2024
@gnecula gnecula force-pushed the export_device_poly2 branch 2 times, most recently from 39937d1 to db4a833 Compare May 20, 2024 13:35
…ber of devices as when exported

Now we allow a module exported for 1 device and not using any sharding annotations
to be called from a computation that uses multiple devices. Such exported modules
can be parallelized trivially point-wise.
@copybara-service copybara-service bot merged commit 1181136 into google:main May 21, 2024
13 checks passed
@gnecula gnecula deleted the export_device_poly2 branch May 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant