-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datatrails: persist search terms and use them to reduce retrieved metric names #87884
Open
darrenjaneczek
wants to merge
10
commits into
main
Choose a base branch
from
datatrails/variable-search-terms
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenjaneczek
changed the title
Datatrails/variable search terms
datatrails: persist search terms and use them to reduce retrieved metric names
May 23, 2024
3 tasks
darrenjaneczek
force-pushed
the
datatrails/variable-search-terms
branch
3 times, most recently
from
May 28, 2024 13:12
50f08ea
to
0a7345c
Compare
darrenjaneczek
force-pushed
the
datatrails/variable-search-terms
branch
from
May 31, 2024 13:26
e45aa29
to
5915eb8
Compare
darrenjaneczek
added
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
labels
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Creates a metric search terms variable.
This variable is stored as a URL parameter, and sent to the prometheus request for metric names.
A limit is added to the prometheus request to prevent an excessive response of metric names, which could lead to a time out. The user is encouraged to add adhoc filters or additional search terms to reduce the number of results returned.
Why do we need this feature?
Three features:
Limitations:
match[]
parameter excludes "lookahead". Instead, we construct a list of expressions out of the search terms, and requestsn
of those terms to be present in the metric name (where n is the number of search terms). This will result in false positiives, such as "go hello" matching "go_gone" since "go" appears twice. The same javascript regular expression is used as before, which would filter out "go_gone" since it lacks "hello". Unfortunately, the limit will include these false positives.Special notes for your reviewer:
Please check that: