Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Test mode 2 dual writer in playlist tests #87938

Merged
merged 1 commit into from
May 16, 2024

Conversation

suntala
Copy link
Contributor

@suntala suntala commented May 15, 2024

What is this feature?

[Add a brief description of what the feature or update does.]

Why do we need this feature?

I missed updating the playlist tests when I added the mode 2 feature flag in #87668. That means the playlist integration tests are currently testing mode 1 behavior. We don't have mode 1 enabled so we should prioritise testing mode 2 behavior. This is a bandaid PR since mode 2 is enabled in dev and ops and the other modes aren't enabled anywhere. We will need to introduce equivalent tests for all the modes though. Will create a subtask/issue to track this.

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@suntala suntala requested a review from a team as a code owner May 15, 2024 20:15
@suntala suntala added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 15, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 15, 2024
@leonorfmartins leonorfmartins merged commit 4867fd3 into main May 16, 2024
23 of 24 checks passed
@leonorfmartins leonorfmartins deleted the suntala/playlist-test-with-mode branch May 16, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants