Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Schedule a shim implementation for recording rules #87939

Merged
merged 5 commits into from
May 21, 2024

Conversation

alexweav
Copy link
Contributor

What is this feature?

Right now, if a recording rule is present in the database it'll be scheduled as an Alert rule. This will immediately fail because recording rules lack some of the alert rule fields.

Here we introduce an alternate rule implementation for recording rules. It's left as a shim for now that doesn't do anything, but it doesn't fail either.

This unblocks work on metrics and tracking health for recording rules without needing to write their full implementation yet. Makes future work easier to parallelize.

Which issue(s) does this PR fix?:

n/a

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@alexweav alexweav requested a review from a team as a code owner May 15, 2024 20:15
@alexweav alexweav requested review from jtheory, rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team May 15, 2024 20:15
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 15, 2024
@alexweav alexweav added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes area/alerting Grafana Alerting labels May 15, 2024
Copy link
Contributor

@rwwiv rwwiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexweav alexweav merged commit 89b54d0 into main May 21, 2024
12 checks passed
@alexweav alexweav deleted the alexweav/recording-rule-shim branch May 21, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Grafana Alerting area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants