[WIP] Extra functionality for queries list page #2534
Conversation
|
Your preview environment pr-2534-bttf has been deployed. Preview environment endpoints are available at: |
Kevin-Chant
force-pushed
the
kc/queries-page-extra-functionality
branch
from
b8d6571
to
028976d
Compare
| async cancelQuery(externalId: string): Promise<void> { | ||
| logger.debug(`Cancel query: ${externalId} - not implemented`); | ||
| } |
There was a problem hiding this comment.
Getting rid of the abstract definition so we can more easily check whether an integration has a cancelQuery defined or not
| querySource: { | ||
| sourceType: "DimensionSlices", | ||
| id: this.model.id, | ||
| }, |
There was a problem hiding this comment.
Checking my understanding here - there's no page to link back to for DimensionSlices, right? I figured it'd be worth storing the source anyway but open to changing that
| querySource: { | ||
| sourceType: "PastExperiments", | ||
| id: this.model.id, | ||
| }, |
There was a problem hiding this comment.
Same question as for DimensionSlices. It seems like a PastExperiments import doesn't have any canonical point to link back to but it might still be worth keeping the source tagged
| @@ -86,6 +92,8 @@ const DataSourceQueries = (): React.ReactElement => { | |||
| ); | |||
| } | |||
|
|
|||
| const supportsQueryCancellation = ["athena", "bigquery"].includes(d.type); | |||
There was a problem hiding this comment.
Is there somewhere better that this can live? The source of truth is really whether the backend integration includes a cancelQuery function so that can't exactly be checked from the frontend code here
| @@ -155,6 +164,36 @@ const DataSourceQueries = (): React.ReactElement => { | |||
| } | |||
| } | |||
|
|
|||
| let LinkToQuerySource = <></>; | |||
| if (query.querySource) { | |||
| // Backlinks are supported for Metrics and Experiments as they have canonical pages to link to | |||
There was a problem hiding this comment.
If there are any other major types I should add support for let me know
| apiCall<Response>( | ||
| `/datasource/${did}/cancel/${query.id}`, | ||
| { | ||
| method: "POST", | ||
| } | ||
| ); |
There was a problem hiding this comment.
I could use some input on what to do with the response to this api call. I wasn't sure what the best way to surface an error message or success status to the user would be, as the UI on this page is already getting somewhat cluttered.
There was a problem hiding this comment.
Does this stab at permissions seem right? Or any obvious changes I should make?
Kevin-Chant
force-pushed
the
kc/queries-page-extra-functionality
branch
from
e1393ab
to
c7c3325
Compare
Features and Changes
Adds a new column to the Queries page of a datasource for actions to be taken on that query.
Initially there are two possible actions:
Currently, only BigQuery and Athena support cancellation, but we can implement the
cancelQueryfunction on more integrations in future PRs.Testing
Run queries from both an experiment & a metric to make sure that the back-linking works correctly.
Screenshots