Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdk connection api endpoint #2542

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

romain-growthbook
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented May 16, 2024

Deploy preview for docs ready!

✅ Preview
https://docs-rpbphklwa-growthbook.vercel.app

Built with commit 16ad6b6.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented May 16, 2024

Your preview environment pr-2542-bttf has been deployed.

Preview environment endpoints are available at:

@romain-growthbook romain-growthbook changed the base branch from main to env-api-endpoints May 30, 2024 14:45
Base automatically changed from env-api-endpoints to main May 30, 2024 16:36

const capabilityParams = [
["encryption", "encryptPayload"],
["remoteEval", "remoteEvalEnabled"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add visualEditor and redirects.

type CababilitiesParams = { [k in CababilitiesParamKey]?: boolean };

const premiumFeatures = [
["encrypt-features-endpoint", "encryptPayload"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add visual-editor, hash-secure-attributes, remote-evaluation, and redirects.

In addition, if the user doesn't have cloud-proxy and IS_CLOUD, then they shouldn't be able to specify any of the proxy settings.

if (payload[param] && !capabilities.includes(capability))
throw new Error(
`SDK version ${sdkVersion} doesn not support ${capability}`
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should differentiate between the version not supporting this feature and the language not supporting it. Basically, check the capabilities of the latest version and then you can say "This isn't supported by this language" vs "You need to update your version"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants