Exp checklist permission mismatch bug. #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2545-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
reviewed
May 17, 2024
| const envs = experiment ? getAffectedEnvsForExperiment({ experiment }) : []; | ||
|
|
||
| if (!context.permissions.canRunExperiment(experiment, envs)) { | ||
| if (!context.permissions.canViewExperimentModal(experiment.project)) { |
There was a problem hiding this comment.
This seems like it should be canUpdateExperiment instead, right?
There was a problem hiding this comment.
DOH. Yes. I've updated the both places to use the canUpdateExperiment.
jdorn
reviewed
May 17, 2024
|
|
||
| if (!context.permissions.canRunExperiment(experiment, envs)) { | ||
| const updatedExperiment = { ...experiment, manualLaunchChecklist: checklist }; | ||
| if (!context.permissions.canUpdateExperiment(experiment, updatedExperiment)) { |
There was a problem hiding this comment.
The 2nd argument should just be the fields that are changing, not the entire updated experiment.
jdorn
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and Changes
Our sentry logs indicated a user received an error when attempting to edit an experiment's checklist.
When digging in, it appeared that this error was thrown for an
analystuser trying to update a manual checklist item on an experiment's checklist. After some digging, I found that on the frontend, when determining whether the user should have edit access, we were checkingcanViewExperimentModalwhich checks thecreateAnalysespermission, but on the backend, we were checkingcanRunExperimentwhich checks therunExperimentspermission.Looking at the roles and policies, an
analystis described as being able to create, edit, and delete experiments, so my understanding is the backend check we were doing was checking too high of a permission level.This PR updates the backend to check the same permission that we're checking on the frontend so no users will get UI that says they can update, but the backend says otherwise.
Testing