Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment page permission fixes #2546

Merged
merged 1 commit into from
May 18, 2024
Merged

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented May 17, 2024

Features and Changes

Back-end permission checks are all working as expected. This PR just updates the front-end to disable buttons in the UI that are just going to result in a back-end error.

Includes the following fixes:

  • "Delete Demo Datasource" button showing up for users without permission to delete
  • Users without update permission able to view and attempt to submit the Analysis Settings modal
  • Users without update permission able to attempt to toggle CUPED on/off
  • Uncaught errors in the CUPED toggle crashed the experiment page (permission errors or others)
  • "Configure experiment dimension slices" showing up for users without permission

@jdorn jdorn requested a review from mknowlton89 May 17, 2024 14:21
Copy link

Your preview environment pr-2546-bttf has been deployed.

Preview environment endpoints are available at:

@jdorn jdorn merged commit fc12b1f into main May 18, 2024
3 checks passed
@jdorn jdorn deleted the experiment-page-permission-fixes branch May 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant