Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mk/info schema refresh bug #2547

Closed
wants to merge 50 commits into from
Closed

Mk/info schema refresh bug #2547

wants to merge 50 commits into from

Conversation

mknowlton89
Copy link
Collaborator

Features and Changes

  • Closes (add link to issue here)

Dependencies

Testing

Screenshots

jdorn and others added 30 commits May 8, 2024 10:59
@jdorn
Add policies layer in between roles and permissions
fac854a
@jdorn
Define policies, role->policies map, and policy->permissions map
5c4e782
@jdorn
Hook up new policy-based roles to existing permissions flow
b57773b
@jdorn
Add new fields to OrganizationModel
b2e6d92
@jdorn
Remove test suite (part of different PR)
818657e
@jdorn
Add isRoleValid checks throughout back-end
1788cb1
@mknowlton89
Merges in main and resolves conflict.
7450d68
@mknowlton89
Fixes broken import paths
2d4950f
@jdorn
Merge remote-tracking branch 'origin/main' into permission-policies
e430fd9
@jdorn
Fix tests, add metadata about policies
7895224
@jdorn
Move isRoleValid and areProjectRolesValid to shared
4b40c2f
@jdorn
Helper function to get default role
5f133b4
@jdorn
Move permission constants to new file, add displayName to policies
9f950ac
@jdorn
Remove old permission-constants file that's not being used
4a23b7f
@jdorn
Change getRoles logic to match design mocks
4e29865
@jdorn
Use getDefaultRole helper throughout codebase
db8b73a
@jdorn
Fix type export
f9e31a7
@jdorn
Add new permission, commercial feature, and back-end routes for manag…
974af56 
…ing custom roles
@mknowlton89
Merges in main and resolves conflicts.
160fcca
@mknowlton89
Fixes lint issues and updates policies.
9bebefb
@mknowlton89
Adds missing 'manageSDKWebhooks' permission to SDKConnectionsFullAcce…
b8d0fed 
…ss policy.
@mknowlton89
Introduce UI for Custom Roles
b641a41
@mknowlton89
Merge branch 'permission-policies' into mk/custom-roles-ui
a505a17
@mknowlton89
Adds basic logic for creating, updating, duplicating, and deleting roles
b40720c
@mknowlton89
Gets basic flow working a bit better and formats the role dropdown wh…
a99c467 
…en adding/updating a user.
@mknowlton89
Merges in main and resolves import conflict.
be07356
@mknowlton89
Removes FactFiltersFullAccess policy
8a0d605
@mknowlton89
Merge branch 'permission-policies' into mk/custom-roles-ui
bedc5b8
@mknowlton89
Changes to improve the duplicate role flow.
603f088
@mknowlton89
Improves UI around role selector, adds wrapper to reduce copy/pasted …
2787e19 
…code, and fixes a few bugs.
@mknowlton89
Cleans up RoleList a bit
bf34a4c
@mknowlton89
Optimizations to improve readability
2d05fa2
@mknowlton89
Small UI tweaks to match the mocks more closely
4a5db5e
@mknowlton89
Hides the Create Custom Role link if the org doesn't have the feature…
eb4d9e1 
… and checks for custom role feature before building the list of roles in the role selector.
@mknowlton89
Adds logic to revert back to collaborator role if org has custom role…
eb54191 
… set as default role and downgrades away from enterprise.
@mknowlton89
Merge branch 'main' into permission-policies
d58484e
@mknowlton89
Merge branch 'permission-policies' into mk/custom-roles-ui
0afe3be
@mknowlton89
Increases role.description limit to 100 characters and ensures we're …
ba8c875 
…passing the orgs custom roles to the front end context.
@mknowlton89
Addresses Jeremys comments
3053445
@mknowlton89
merging in main and resolving conflicts
28ce4b7
@mknowlton89
Merging in one last conflict
fd08e68
@mknowlton89
Removes duplicate commercial feature on enterprise plan
094fae8
@mknowlton89
Updates the default role selector to match the single role selector.
0d3131a
@mknowlton89
Updates the permission check to actually call the function.
40d019f
@mknowlton89
Introduce deactivate role flow
f4e6106
@mknowlton89
Built backend flow and wired it up to the frontend
d91fc7c
@mknowlton89
Adds protection around deactivating an org's default role and updates…
7e8fb52 
… styling of role selector to handle all reserved roles being deactivated.
@mknowlton89
Normalizes the default role selector with the single role selector.
c1f47dc
@mknowlton89
Bug - Not checking permission before refreshing info schema.
1386e2d
@mknowlton89 mknowlton89 self-assigned this May 20, 2024
@mknowlton89 mknowlton89 changed the base branch from main to mk/deactive-role-flow May 20, 2024 11:12
@mknowlton89 mknowlton89 changed the base branch from mk/deactive-role-flow to main May 20, 2024 11:13
@mknowlton89
Copy link
Collaborator Author

Closing in lieu of this PR instead - #2550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mknowlton89 mknowlton89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mknowlton89 @jdorn