Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MDM Transaction Context for further downstream processing giving … #5897

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jkiddo
Copy link
Contributor

@jkiddo jkiddo commented May 1, 2024

…interceptors a better chance of figuring out what happened.

…interceptors a better chance of figuring out what happened.
Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, recommend adding a changelog in the 7_4_0 folder (or if you want this to merge into the May release, repoint your PR to rel_7_2 and put this change in the 7_2_0 changelog folder.

@jkiddo jkiddo changed the base branch from master to rel_7_2 May 1, 2024 15:20
@jkiddo jkiddo changed the base branch from rel_7_2 to master May 1, 2024 16:07
Copy link
Contributor

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipelines for this PR failed on MdmOperationPointcutsIT. mergeGoldenResources_withInterceptor_firesHook

I think this may be something intermittent, as it runs correctly locally.

BUT, it does point to a spot we could add test coverage:

Could we add MdmTransactionContext theContext to the params in that test and put in some asserts?

@Hook(Pointcut.MDM_POST_MERGE_GOLDEN_RESOURCES)
				void onUpdate(RequestDetails theDetails, MdmMergeEvent theEvent, MdmTransactionContext theContext) {
					called.getAndSet(true);
					assertEquals("Patient/" + gp1.getIdPart(), theEvent.getFromResource().getId());
					assertEquals("Patient/" + gp2.getIdPart(), theEvent.getToResource().getId());
					assertTrue(theEvent.getFromResource().isGoldenResource() && theEvent.getToResource().isGoldenResource());
				        //FIXME Put some real asserts here
					assertEquals(SomeCondition, theContext.someMethod());
				}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants